src/components/LocationProvider/LocationProvider.tsx (1)

86-114: Refactor duplicated canonical redirect block into a local helper.

The redirect-hash construction appears twice with identical logic. Extracting it avoids branch drift in future edits.

♻️ Suggested deduplication

   const handleHashChange = useCallback(() => {
     const { rest: newHash, search, section, split } = extractSearchParams(window.location.hash);

     const resolvedSplit = split ? (resolveFullVersion(split) ?? undefined) : undefined;
+    const rewriteCanonicalHash = (version: string) => {
+      const redirectHash = locationParamsToHash({ version, search, section, split: resolvedSplit }, metadata, {
+        includeSearchSection: true,
+      });
+      window.location.hash = redirectHash;
+    };

     if (!newHash.startsWith(SEGMENT_SEPARATOR)) {
       const version = metadata.latest;
       setLocationParams((params) => ({
         ...params,
         version,
         search,
         section,
         split: resolvedSplit,
       }));
-      const redirectHash = locationParamsToHash({ version, search, section, split: resolvedSplit }, metadata, {
-        includeSearchSection: true,
-      });
-      window.location.hash = redirectHash;
+      rewriteCanonicalHash(version);
       return;
     }
@@
     if (!fullVersion) {
       const version = metadata.latest;
       setLocationParams((params) => ({
         ...params,
         version,
         search,
         section,
         split: resolvedSplit,
       }));
-      const redirectHash = locationParamsToHash({ version, search, section, split: resolvedSplit }, metadata, {
-        includeSearchSection: true,
-      });
-      window.location.hash = redirectHash;
+      rewriteCanonicalHash(version);
       return;
     }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/components/LocationProvider/LocationProvider.tsx` around lines 86 - 114,
There are two identical blocks that build a canonical redirect hash and set
state/window.location.hash; extract them into a local helper (e.g.,
redirectToCanonical) inside LocationProvider.tsx that accepts a version (or uses
metadata.latest when needed), calls setLocationParams with { version, search,
section, split: resolvedSplit }, constructs the redirectHash via
locationParamsToHash(..., metadata, { includeSearchSection: true }), and sets
window.location.hash = redirectHash; then replace both duplicated blocks with a
call to this helper (use resolveFullVersion when computing the version before
calling it).

tools/snapshot-tests/tests/url-params.spec.ts (1)

11-15: Avoid duplicated selector literals in getScrollTop.

Reuse PDF_SCROLL_CONTAINER via page.evaluate arg to prevent selector drift.

🧩 Small maintainability tweak

 async function getScrollTop(page: import("@playwright/test").Page) {
-  return await page.evaluate(() => {
-    const viewer = document.querySelector(".pdfViewer");
+  return await page.evaluate((selector) => {
+    const viewer = document.querySelector(selector);
     return viewer?.parentElement?.scrollTop ?? 0;
-  });
+  }, PDF_SCROLL_CONTAINER);
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tools/snapshot-tests/tests/url-params.spec.ts` around lines 11 - 15, The
getScrollTop function duplicates the ".pdfViewer" selector literal; change it to
accept/use the shared PDF_SCROLL_CONTAINER constant by passing it into
page.evaluate as an argument (e.g., call page.evaluate((sel) => { const viewer =
document.querySelector(sel); ... }, PDF_SCROLL_CONTAINER)) so the selector is
not hard-coded inside the evaluated function; update getScrollTop to reference
PDF_SCROLL_CONTAINER and remove the inline string literal to prevent selector
drift.